Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-canonical paths for mount paths. #942

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Use non-canonical paths for mount paths. #942

merged 1 commit into from
Jul 16, 2022

Commits on Jul 16, 2022

  1. Use non-canonical paths for mount paths. 

    Symlinks and canonical paths can destroy assumptions about paths: say I have a file at `/tmp/path/to/file` I reference in my crate, and ask to mount `/tmp/path/to` on the container. Currently, on macOS, since `/tmp` is a symlink to `/private/tmp`, the code that expects `/tmp/path/to/file` will fail because in the container it will be mounted at `/private/tmp/path/to/file`.

Also fix device_ns parsing with drive letters. Fixes a minor bug where the host root instead of the var names was passed as the environment variable.
    @Alexhuszagh
    Alexhuszagh committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    b3a62ea View commit details
    Browse the repository at this point in the history