Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.8 compatibility #1258

Closed
wants to merge 1 commit into from
Closed

add python 3.8 compatibility #1258

wants to merge 1 commit into from

Conversation

om26er
Copy link
Contributor

@om26er om26er commented Oct 17, 2019

Fixes #1193

@oberstet
Copy link
Contributor

no, this is wrong: it exports new symbols (get_clock) which are then used on linux too - where is (if any) should use the existing rtime

@oberstet oberstet closed this Oct 18, 2019
@oberstet
Copy link
Contributor

pls see my comment here #1193 (comment)

@om26er
Copy link
Contributor Author

om26er commented Oct 18, 2019

@oberstet do we also want to deal with examples as well, because they use time.clock(), if not, then yes, the change can be as simple as that.

@oberstet
Copy link
Contributor

ah, right. the examples should use autobahn.util.rtime ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

time.clock is removed in Python 3.8
2 participants
@om26er @oberstet