Add py38 compatibility #1259
Merged
Add py38 compatibility #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankravets
reviewed
Oct 18, 2019
| @@ -463,7 +463,10 @@ def generate_serial_number(): | |||
| # first call to this function, as a floating point number, based on the | |||
| # Win32 function QueryPerformanceCounter(). The resolution is typically | |||
| # better than one microsecond | |||
| _rtime = time.clock | |||
| if sys.version_info >= (3, 8): | |||
There was a problem hiding this comment.
perf_counter was added in Python 3.3. Why we can't use it for all Python 3.3+ line?
time.clock produces a warning on <Python 3.8
because we don't want to when on linux |
|
@oberstet what do you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 at #1193