Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails with unresolved import self::std::hint` #412

Closed
jeehoonkang opened this issue Aug 27, 2019 · 1 comment · Fixed by #428
Closed

CI fails with unresolved import self::std::hint` #412

jeehoonkang opened this issue Aug 27, 2019 · 1 comment · Fixed by #428

Comments

@jeehoonkang
Copy link
Contributor

https://travis-ci.org/crossbeam-rs/crossbeam/jobs/577310627#L270

I checked in my local machine that it happens in the current master for Rust 1.26.0.
@drrlvn drrlvn mentioned this issue Sep 1, 2019
Closed
@Vtec234
Copy link
Member

Vtec234 commented Sep 17, 2019 •
edited
Loading

Do we still support 1.26.0?
This is due to a change in lazy_static, where version 1.3.0 still works but 1.4.0 doesn't. The oldest rustc supported by 1.4.0 is 1.27.2, while for 1.3.0 it was 1.24.1.

@jeehoonkang jeehoonkang mentioned this issue Oct 15, 2019
Closed
bors bot added a commit that referenced this issue Oct 15, 2019
@bors @jeehoonkang
Merge #429
4212365 
429: Limit lazy_static version r=jeehoonkang a=jeehoonkang

Closes #412 

It's necessary to accept #428, which is fixing a breakage of Rust ecosystems...

Co-authored-by: Jeehoon Kang <jeehoon.kang@kaist.ac.kr>
@taiki-e taiki-e mentioned this issue Oct 15, 2019
Merged
bors bot added a commit that referenced this issue Oct 15, 2019
@bors @taiki-e
Merge #428
aeb311d 
428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 
Fixes #412


Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit that referenced this issue Oct 16, 2019
@bors @taiki-e
Merge #428
cdc4379 
428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e

`target_has_atomic = "cas"` was removed in rust-lang/rust#65214.

Fixes rust-lang/rust#65424 
Fixes #412


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors bors bot closed this as completed in a5859f3 Oct 16, 2019
@Vtec234 Vtec234 mentioned this issue Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jeehoonkang @Vtec234