-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamically sized types #452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jeehoonkang
force-pushed
the
dst
branch
2 times, most recently
from
May 20, 2020 11:34
d8dff7a
to
634c72f
Compare
I think it's ready to be merged. If everyone's happy with it, I'll merge it 3 days later. |
taiki-e
reviewed
May 21, 2020
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supersedes #209 for supporting dynamically sized types (DST) in Crossbeam. It's much cleaner and less intrusive than the previous attempts in that it doesn't introduce another
Atomic
type.Atomic<T>
is still there without significant changes.The key idea is (1) instead of requiring the condition on
T: Sized
, (2) requiringT: Pointable
that means an object of typeT
can be pointed to by a single word. For instance,Atomic
becomes:pub struct Atomic<T: ?Sized + Pointable> { ... }
.It is breaking the backward compatibility in that it
(1) increases the minimum required Rust version to 1.36 (fornowMaybeUninit
) and (2)const fn Atomic::null()
is Nightly only.