Use "closed" instead of "disconnected" #561
Conversation
|
My main worry about this change is that it would break too much existing code for very little benefit. To see if that is true, I cloned the Servo repository and grepped it for 'disconnected'. I only found one instance of breakage: This makes me feel better considering that Servo is a big codebase. Still... I'm a bit worried that other projects might be matching on error types more often. Crossbeam might have reached the point where it's so widespread that stability is preferable over minor API improvements. What do you think? |
|
Hmm, given that the current term is not wrong, the cost of changing this will probably be greater than the benefit. (I found nearly 50 "Try(Send|Recv)Error::Disconnected" in tikv.) What I was thinking was mainly about the impact on methods that may be added in the future, such as disconnect/close and is_disconnected/is_closed. (As time goes by, it becomes more difficult to standardize terms within the ecosystem. But in reality, it may already be impossible...) |
|
Yeah I think that ship has sailed :) We'll probably never agree on a 'standard' channel interface, but that's okay. I don't think it's a super important problem worth solving. We're fine with a bunch similar but slightly different interfaces... |
|
Ok! Closing in favor of the above opinion that the benefits of doing this are not enough. |
Addresses #256 (comment)