Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): changed logger to ISO8601TimeEncoder #1626

Merged

Conversation

haarchri
Copy link
Member

Signed-off-by: Christopher Paul Haar christopherpaul.haar@dkb.de

Description of your changes

changed logger to ISO8601TimeEncoder

old:

1.6656692709539523e+09     DEBUG   provider-aws    External resource is up to date {"controller": "managed/subnet.ec2.aws.crossplane.io", "request": "/sample-subnet2", "uid": "99db324c-c44b-4395-b626-b1cbd543255e", "version": "1317437", "external-name": "subnet-0111adcde1b842c07", "requeue-after": "1.6656692755539544e+09 "}

new:

2023-01-10T09:43:02.292+0100    DEBUG   provider-aws    External resource is up to date {"controller": "managed/subnet.ec2.aws.crossplane.io", "request": "/sample-subnet2", "uid": "99db324c-c44b-4395-b626-b1cbd543255e", "version": "1317437", "external-name": "subnet-0111adcde1b842c07", "requeue-after": "2023-01-10T09:44:02.292+0100"}

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Christopher Paul Haar <christopherpaul.haar@dkb.de>
@haarchri haarchri requested a review from muvaf January 10, 2023 09:29
@chlunde
Copy link
Collaborator

chlunde commented Jan 12, 2023

Nice. A couple of days ago I noticed this in the release notes for controller-runtime:
kubernetes-sigs/controller-runtime@60e524b

RFC3339TimeEncoder

Maybe we should use that instead to align with the rest of the k8s community

@haarchri
Copy link
Member Author

okay lets have a update in one of the following releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants