Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Queue and Table related encryption operations #233

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

craigbryson
Copy link
Contributor

Signed-off-by: craigbryson 37695591+craigbryson@users.noreply.github.com

Description of your changes

Fixes #232

Removes options for table and queue encryption since these cannot be modified. Accounts now reconcile successfully.

There are some potentially breaking changes to CRDs (removal) not sure how best to handle these?

I have:

  • [ X] Read and followed Crossplane's contribution process.
  • [ X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally provisioning a storage account as per the issue - account now reconciles successfully. No failed API operations are shown in the activity log

Signed-off-by: craigbryson <37695591+craigbryson@users.noreply.github.com>
@muvaf muvaf self-requested a review March 23, 2021 17:51
@muvaf
Copy link
Member

muvaf commented Mar 23, 2021

Thanks @craigbryson !

From the following comment in SDK, I see that these fields are read-only:

	// Table - READ-ONLY; The encryption function of the table storage service.
	Table *EncryptionService `json:"table,omitempty"`
	// Queue - READ-ONLY; The encryption function of the queue storage service.
	Queue *EncryptionService `json:"queue,omitempty"`

So, it should be fine to remove them.

I wonder if we can show them in status but it seems like this controller is one of the oldest controllers and maybe the only one that doesn't use the generic managed reconciler, hence due a schema and controller change. So, no need for that for now. Added a comment to #90

@muvaf muvaf merged commit c9749e0 into crossplane-contrib:master Mar 23, 2021
@craigbryson craigbryson deleted the encryption branch September 10, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Account unsuccessfully tries to disable Table Encryption
2 participants