Enum fix in SQL #234
Merged
Enum fix in SQL #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le the code expects another one. so we just opt out of using an enum for minimum tls version Signed-off-by: Muvaffak Onus <me@muvaf.com>
hasheddan
reviewed
Mar 24, 2021
| @@ -29,5 +29,5 @@ require ( | |||
| k8s.io/apimachinery v0.20.1 | |||
| k8s.io/client-go v0.20.1 | |||
| sigs.k8s.io/controller-runtime v0.8.0 | |||
| sigs.k8s.io/controller-tools v0.3.0 | |||
There was a problem hiding this comment.
@muvaf was bumping version here intentional?
There was a problem hiding this comment.
Yes, make reviewable made some changes I think not compatible with clean CRD target. So, I just bumped it to make it inline with other providers.
hasheddan
approved these changes
Mar 24, 2021
Signed-off-by: Muvaffak Onus <me@muvaf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Weirdly, Azure SDK says it expects
TLS12format while their enum constants areTLS1_2. In a manual test for #230 , I realized our example is not working due to this. This PR removes the enum and let Azure return error they want in case format is wrong.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually.