-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetworkInterface support #269
base: master
Are you sure you want to change the base?
NetworkInterface support #269
Conversation
e6e9620
to
0ae14d8
Compare
0ae14d8
to
b963747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vaspahomov,
Thank you for working on introducing NetworkInterface support. This PR embodies #264 and thus, I did not review PublicIPAddress code in this PR, as #264 is already reviewed.
Comments/discussions are very similar to what we have in #264 and should be relatively straightforward to address. Please also do not forget to rebase and sign your commits.
Thank you for all your efforts, very much appreciated! And looking forward to merging all these PRs into the provider.
Signed-off-by: vaspahomov <vaspahomov@yandex-team.ru> Signed-off-by: vaspahomov <vas2142553@gmail.com>
Signed-off-by: vaspahomov <vas2142553@gmail.com>
b963747
to
6e88352
Compare
Hi! @ulucinar I committed fixed |
I want to add VM instances support in crossplane/provider-azure.
This is second part of patch. First: #264
Description of your changes
Add support of NetworkInterface support.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Same like in other resources like Subnet and VisrtualNetwork. And also manually tested