NetworkInterface support #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaspahomov
force-pushed
the
feature/network-interface-support
branch
2 times, most recently
from
e6e9620
to
0ae14d8
Compare
vaspahomov
force-pushed
the
feature/network-interface-support
branch
from
0ae14d8
to
b963747
Compare
ulucinar
reviewed
Sep 22, 2021
There was a problem hiding this comment.
Hi @vaspahomov,
Thank you for working on introducing NetworkInterface support. This PR embodies #264 and thus, I did not review PublicIPAddress code in this PR, as #264 is already reviewed.
Comments/discussions are very similar to what we have in #264 and should be relatively straightforward to address. Please also do not forget to rebase and sign your commits.
Thank you for all your efforts, very much appreciated! And looking forward to merging all these PRs into the provider.
Signed-off-by: vaspahomov <vaspahomov@yandex-team.ru> Signed-off-by: vaspahomov <vas2142553@gmail.com>
Signed-off-by: vaspahomov <vas2142553@gmail.com>
vaspahomov
force-pushed
the
feature/network-interface-support
branch
from
b963747
to
6e88352
Compare
|
Hi! @ulucinar I committed fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add VM instances support in crossplane/provider-azure.
This is second part of patch. First: #264
Description of your changes
Add support of NetworkInterface support.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Same like in other resources like Subnet and VisrtualNetwork. And also manually tested