Remove FieldRequired for EnableVMProtection VNET property #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting this property to False in the Crossplane VirtualNetwork CR, the controller finds itself constantly reconciling actual and desired state. This leads to a lot of instability when trying to create resources in that VNET, as there is never any convergence. Adding a few log messages in the provider, I observed that there was always a mismatch between the EnableVMProtection property for the desired object (pointer to a boolean value set to false) and the one for the actual object obtained from the Azure SDK (which is nil). So it seems that using FieldRequired for EnableVMProtection may not be accurate, at least not with the version of the SDK currently used by Crossplane. Signed-off-by: Antonin Bas <abas@vmware.com>
|
EnableVMProtection is a legacy flag, that's why now azure sends nil value. |
|
@vaspahomov thanks for the explanation! @antoninbas thanks for the change! have you got to test whether this change fixes the problem you're experiencing? |
Signed-off-by: Antonin Bas <abas@vmware.com>
|
@muvaf yes I can confirm that I have tested the change with my Azure account and that it resolves the issue. With this change VNET reconciliation was successful. I also pushed a new commit as I forgot to update a unit test originally... |
antoninbas
deleted the
remove-FieldRequired-for-EnableVMProtection-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When setting this property to False in the Crossplane VirtualNetwork CR,
the controller finds itself constantly reconciling actual and desired
state. This leads to a lot of instability when trying to create
resources in that VNET, as there is never any convergence.
Adding a few log messages in the provider, I observed that there was
always a mismatch between the EnableVMProtection property for the
desired object (pointer to a boolean value set to false) and the one
for the actual object obtained from the Azure SDK (which is nil).
So it seems that using FieldRequired for EnableVMProtection may not be
accurate, at least not with the version of the SDK currently used by
Crossplane.
Signed-off-by: Antonin Bas abas@vmware.com
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Created Vnets with EnableVMProtection set to false and looked at reconciliation logs.