Add global poll interval flag #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
commented
Aug 18, 2021
| func Setup(mgr ctrl.Manager, l logging.Logger, rl workqueue.RateLimiter) error { | ||
| func Setup(mgr ctrl.Manager, l logging.Logger, rl workqueue.RateLimiter, poll time.Duration) error { |
There was a problem hiding this comment.
The passing of the poll interval through the various nested syncers / updaters in the storage controllers is not super clean, but I opted to go for path of least resistance here since these controllers need to be refactored to use the managed reconciler anyway.
Adds a flag to provider entrypoint for setting the happy path poll interval. Defaults to 1 minute. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Passes the value of the poll interval flag to all controllers such that it can be set globally via flag. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
poll-interval
branch
from
9ede6db
to
9067597
Compare
turkenh
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a
--poll-intervalflag to provider, which is passed to all controllers to set their polling interval in the reconciliation happy path.Note to reviewers: these changes are almost entirely find and replace.
xref crossplane/crossplane-runtime#253
Fixes #282
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
See crossplane-contrib/provider-aws#741 for testing steps.