-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/keyvault secret #289
Feature/keyvault secret #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid plaintext string to hold sensitive data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @G5Olivieri for working on this!
I see no blockers in this PR. I have some comments to discuss a few issues, and some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you please rebase this PR and make sure all your commits are signed following the guide here. We also require them to be signed-off using something similar to git commit -s
(they already are signed-off btw). git log --show-signature
should display commit signatures.
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
9853799
to
6fafd2d
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
203570f
to
76d1384
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
76d1384
to
8c794f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this resource @G5Olivieri!
Description of your changes
Add support for Azure Key Vault Secret.
The Key Vault Secret implementation only manage Key Vault Secret, so the Key Vault must be created early.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested