Feature/keyvault secret #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnatan
suggested changes
Sep 8, 2021
ulucinar
requested changes
Sep 21, 2021
There was a problem hiding this comment.
Thank you @G5Olivieri for working on this!
I see no blockers in this PR. I have some comments to discuss a few issues, and some suggestions.
ulucinar
reviewed
Sep 21, 2021
There was a problem hiding this comment.
Also, could you please rebase this PR and make sure all your commits are signed following the guide here. We also require them to be signed-off using something similar to git commit -s (they already are signed-off btw). git log --show-signature should display commit signatures.
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
G5Olivieri
force-pushed
the
feature/keyvault-secret
branch
from
9853799
to
6fafd2d
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
G5Olivieri
force-pushed
the
feature/keyvault-secret
branch
from
203570f
to
76d1384
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
G5Olivieri
force-pushed
the
feature/keyvault-secret
branch
from
76d1384
to
8c794f6
Compare
ulucinar
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for Azure Key Vault Secret.
The Key Vault Secret implementation only manage Key Vault Secret, so the Key Vault must be created early.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested