Feature/add public access in postgresql #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
reviewed
Sep 21, 2021
There was a problem hiding this comment.
Thank you very much for the PR @G5Olivieri. Could you please make sure all your commits are signed following the guide here. We also require them to be signed-off using something similar to git commit -s (they already are signed-off btw).
Regarding the bug you refer to in the description, could you please make sure that we have a bug report in the upstream repo, i.e., crossplane/provider-azure?
Thank you!
G5Olivieri
force-pushed
the
feature/add-public-access-in-postgresql
branch
from
4a54380
to
ee1e3af
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
G5Olivieri
force-pushed
the
feature/add-public-access-in-postgresql
branch
from
ee1e3af
to
2cf7d16
Compare
|
LGTM, thank you @G5Olivieri! |
ulucinar
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support to PublicNetworkAccess field in PostgreSQLServer only.
This implementation is initially for internal use within Stone. For this reason that there is only an implementation for PostgreSQL and not MySQL. The burden of this is that the field is available in MySQL due to the structure of the types and is completely ignored in the MySQLServer CRD.
Fixes #240
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Disclaimer
Before to test see stone-payments#3 talk about a bug that affect this change.