-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add public access in postgresql #293
Feature/add public access in postgresql #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR @G5Olivieri. Could you please make sure all your commits are signed following the guide here. We also require them to be signed-off using something similar to git commit -s
(they already are signed-off btw).
Regarding the bug you refer to in the description, could you please make sure that we have a bug report in the upstream repo, i.e., crossplane/provider-azure?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are using Go v1.17 for your builds. Could you please use Go v1.16 as it's the current version in our CI workflow as specified here.
4a54380
to
ee1e3af
Compare
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
Signed-off-by: Glayson Olivieri <glayson.murollo75@gmail.com>
ee1e3af
to
2cf7d16
Compare
LGTM, thank you @G5Olivieri! |
Description of your changes
Add support to PublicNetworkAccess field in PostgreSQLServer only.
This implementation is initially for internal use within Stone. For this reason that there is only an implementation for PostgreSQL and not MySQL. The burden of this is that the field is available in MySQL due to the structure of the types and is completely ignored in the MySQLServer CRD.
Fixes #240
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Disclaimer
Before to test see stone-payments#3 talk about a bug that affect this change.