Add DNS Service Zone MR #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
dns-service
branch
3 times, most recently
from
82aee17
to
a9e502a
Compare
ulucinar
reviewed
Jan 19, 2022
sergenyalcin
force-pushed
the
dns-service
branch
2 times, most recently
from
fde0e73
to
e44687d
Compare
ulucinar
reviewed
Jan 20, 2022
|
The reasoning behind my suggestion of capitalizing DNS record type names comes from the DNS RFC: |
ulucinar
reviewed
Jan 20, 2022
ulucinar
reviewed
Jan 20, 2022
There was a problem hiding this comment.
I've left some nitpicks for you to consider. As long as we behave correctly, the decision is yours. Thank you very much @sergenyalcin.
sergenyalcin
force-pushed
the
dns-service
branch
2 times, most recently
from
289ba35
to
c84be0c
Compare
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
dns-service
branch
from
c84be0c
to
f441145
Compare
ulucinar
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Thank you @sergenyalcin for working on this PR, very much appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #266
Implementation of DNS Zone MR. The implementation of the resource is done on the Network API Group. Because when you want to create a DNS Zone via az cli, you need to run
az network dns zone createcommand. This may indicate that it would be correct for the DNS Zone resource to be in this API Group.Every field in the Resource's Spec was not used in the update check. Since some fields are immutable, the fields that are likely to be updated have been selected and checked (pkg/clients/network/network.go:162)
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested