Ignore minimalTlsVersion mismatch when the sslEnforcement is disabled #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
muvaf
reviewed
Nov 30, 2021
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
ulucinar
reviewed
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergen Yalçın yalcinsergen97@gmail.com
Description of your changes
Fixes #307
This PR solves the problem that
IsPostgreSQLUpToDatefunction always returns false. When the value ofsslEnforcementisDisabled, theminimalTlsVersionmismatch is ignored.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
A PostgreSqlServer was provisioned by using example manifest (value of
sslEnforcementisDisabled). Then I observed that, theIsPostgreSQLUpToDatereturned true despite there is a mismatch between the values ofminimalTlsVersion.A PostgreSqlServer was provisioned by using example manifest (value of
sslEnforcementisEnabled, value ofminimalTlsVersionisTLS1_2). Then I observed that, cloud resource created with proper values andIsPostgreSQLUpToDatedid not return false.