Actually cache the go build cache between CI runs #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build submodule currently overrides XDG_CACHE_HOME in order to force the Helm 3 to use the .work/helm directory. This causes Go on Linux machines to use that directory as the build cache as well. We should adjust this behavior in the build submodule because it is also causing Linux users to duplicate their build cache, but for now we just make it easier to identify its location in CI so that we cache between builds. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates CI workflow to cache based on go.cachedir to work around the fact that we override the GOCACHE in our make context due to the inclusion of helm.mk. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
ulucinar
approved these changes
Dec 6, 2021
|
Thank you @hasheddan for hunting this issue down. |
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The build submodule currently overrides XDG_CACHE_HOME in
order to force the Helm 3 to use the .work/helm directory. This causes Go on
Linux machines to use that directory as the build cache as well. We should
adjust this behavior in the build submodule because it is also causing Linux
users to duplicate their build cache, but for now we just make it easier to
identify its location in CI so that we cache between builds.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates CI workflow to cache based on go.cachedir to work around the
fact that we override the GOCACHE in our make context due to the
inclusion of helm.mk.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
See crossplane/crossplane#2742 for more details -- we are seeing drastic improvements (as would be expected now that we are actually caching) in Crossplane CI.