Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to v1.17 #333

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Apr 5, 2022

Signed-off-by: Alper Rifat Ulucinar ulucinar@users.noreply.github.com

Description of your changes

This PR bumps provider-azure Go module version to v1.17.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

With make reviewable.
[contribution process]: https://git.io/fj2m9

@ulucinar ulucinar force-pushed the bump-go-v1.17 branch 3 times, most recently from 879bcbf to 85c9703 Compare April 5, 2022 10:59
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Copy link
Contributor

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

echo
# we replace empty dir with our PVC so that the /cache dir in the kind node
# container is exposed to the crossplane pod
"${HELM3}" install crossplane --namespace crossplane-system crossplane-master/crossplane --version ${chart_version} --devel --wait --set packageCache.pvc=package-cache
"${HELM3}" install crossplane --namespace crossplane-system crossplane-stable/crossplane --version 1.6.4 --wait --set packageCache.pvc=package-cache
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will be able to switch to the latest Crossplane with @turkenh's ESS support PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is related to ESS.

@ulucinar ulucinar merged commit 226a6e7 into crossplane-contrib:master Apr 5, 2022
@ulucinar ulucinar deleted the bump-go-v1.17 branch April 5, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants