Add nil check for IPConfigurationPropertiesFormat #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
ulucinar
reviewed
May 13, 2022
| @@ -182,7 +182,7 @@ func GeneratePublicIPAddressObservation(az networkmgmt.PublicIPAddress) *v1alpha | |||
| v.ID = azure.ToString(az.ID) | |||
| v.Address = azure.ToString(az.IPAddress) | |||
| v.Version = string(az.PublicIPAddressVersion) | |||
| if az.IPConfiguration != nil { | |||
| if az.PublicIPAddressPropertiesFormat != nil && az.PublicIPAddressPropertiesFormat.IPConfiguration != nil && az.PublicIPAddressPropertiesFormat.IPConfiguration.IPConfigurationPropertiesFormat != nil { | |||
| v.IPConfiguration = &v1alpha3.IPConfiguration{ | |||
| PrivateIPAllocationMethod: string(az.IPConfiguration.PrivateIPAllocationMethod), | |||
There was a problem hiding this comment.
Are all the referenced fields (PrivateIPAllocationMethod, PrivateIPAddress and ProvisioningState) embedded by the same struct (IPConfigurationPropertiesFormat)?
There was a problem hiding this comment.
Hi @ulucinar I checked, all the referenced fields are embedded by the same struct.
ulucinar
approved these changes
May 17, 2022
|
Thank you @sergenyalcin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes the nil pointer issue for the PublicIPAddress resource. When IPConfiguration field is not nil, we need to check whether the IPConfigurationPropertiesFormat (embedded) is nil because we are trying to access the fields of the embedded struct. For example;
PrivateIPAllocationMethod,PrivateIPAddress,ProvisioningState.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This PR was tested by filling manually the IPConfiguration field. Then the nil pointer issue was not observed.