-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bundled packages and update CI to dual publish to DockerHub and Upbound Marketplace #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates build submodule to latest to consume xpkg.mk. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates to go1.18 and fixes linter errors that came along with the golangci-lint bump. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Drops all deprecated annotations from the provider-aws crossplane.yaml. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Drops the spec from the crossplane.yaml as bundled images will now be used for provider-azure. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Renames the single controller image to provider-azure. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates package base image to use distroless static nonroot instead of defaulting to outdated alpine image. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates provider controller image building to use imagelight for enhanced flexibility. Publish and promotion is deferred to xpkg machinery. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds the xpkg machinery to Makefile and updates other components to be compatible. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Forces image to be built before building xpkg, ensuring that the image is in the daemon before we try to use it as base. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates integration tests to consume the xpkg image that is built. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates integration tests to consume latest stabled version of Crossplane. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
32f8374
to
16eb8a0
Compare
16eb8a0
to
ae437fa
Compare
Adds a login step to publish artifacts workflow for xpkg.upbound.io. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
ae437fa
to
6c0fbe7
Compare
negz
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as crossplane-contrib/provider-gcp#456 (comment), but otherwise this LGTM.
negz
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates to go1.18 and fixes linter errors that came along with the
golangci-lint bump.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Drops the spec from the crossplane.yaml as bundled images will now be
used for provider-azure.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates provider controller image building to use imagelight for
enhanced flexibility. Publish and promotion is deferred to xpkg
machinery.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates package base image to use distroless static nonroot instead of
defaulting to outdated alpine image.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates integration tests to consume latest stabled version of
Crossplane.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #327
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested