-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to push to crossplane-contrib org #353
Conversation
Updates package source to point to the crossplane-contrib GitHub org. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates Makefile to push to crossplane-contrib on Upbound Marketplace and crossplanecontrib on DockerHub. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the AWS change
Updates all GitHub workflows to use the crossplane-contrib Docker user. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronME are you referencing the corresponding change in provider-aws? crossplane-contrib/provider-aws#1514
Sorry, no. I was referencing the changes to the AWS_ vars. Not sure how
changing dockerhub repo requires changing those
…On Wed, Oct 5, 2022 at 11:37 Daniel Mangum ***@***.***> wrote:
***@***.**** commented on this pull request.
@AaronME <https://github.com/AaronME> are you referencing the
corresponding change in provider-aws? crossplane-contrib/provider-aws#1514
<crossplane-contrib/provider-aws#1514>
—
Reply to this email directly, view it on GitHub
<#353 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPKPJEMZWJFH6EKHM4NHOTWBXDF3ANCNFSM6AAAAAAQ5Z4FQE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronME none of the AWS_*
vars are changed in this PR -- are you saying you think they should be?
I see. I misread the diff on line 42 of promote.yaml
I withdraw my comment
…On Wed, Oct 5, 2022 at 11:43 Daniel Mangum ***@***.***> wrote:
***@***.**** commented on this pull request.
@AaronME <https://github.com/AaronME> none of the AWS_* vars are changed
in this PR -- are you saying you think they should be?
—
Reply to this email directly, view it on GitHub
<#353 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPKPJFLFLWLHCBQF6GR55DWBXD4ZANCNFSM6AAAAAAQ5Z4FQE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description of your changes
Updates package source to point to the crossplane-contrib GitHub org.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates Makefile to push to crossplane-contrib on Upbound Marketplace
and crossplanecontrib on DockerHub.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates all GitHub workflows to use the crossplane-contrib Docker user.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Verified these updates work correctly in GCP and AWS providers.