Update to push to crossplane-contrib org #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates package source to point to the crossplane-contrib GitHub org. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates Makefile to push to crossplane-contrib on Upbound Marketplace and crossplanecontrib on DockerHub. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
AaronME
approved these changes
Oct 5, 2022
Updates all GitHub workflows to use the crossplane-contrib Docker user. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Oct 5, 2022
There was a problem hiding this comment.
@AaronME are you referencing the corresponding change in provider-aws? crossplane-contrib/provider-aws#1514
|
Sorry, no. I was referencing the changes to the AWS_ vars. Not sure how
changing dockerhub repo requires changing those
…On Wed, Oct 5, 2022 at 11:37 Daniel Mangum ***@***.***> wrote:
***@***.**** commented on this pull request.
@AaronME <https://github.com/AaronME> are you referencing the
corresponding change in provider-aws? crossplane-contrib/provider-aws#1514
<crossplane-contrib/provider-aws#1514>
—
Reply to this email directly, view it on GitHub
<#353 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPKPJEMZWJFH6EKHM4NHOTWBXDF3ANCNFSM6AAAAAAQ5Z4FQE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I see. I misread the diff on line 42 of promote.yaml
I withdraw my comment
…On Wed, Oct 5, 2022 at 11:43 Daniel Mangum ***@***.***> wrote:
***@***.**** commented on this pull request.
@AaronME <https://github.com/AaronME> none of the AWS_* vars are changed
in this PR -- are you saying you think they should be?
—
Reply to this email directly, view it on GitHub
<#353 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPKPJFLFLWLHCBQF6GR55DWBXD4ZANCNFSM6AAAAAAQ5Z4FQE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates package source to point to the crossplane-contrib GitHub org.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates Makefile to push to crossplane-contrib on Upbound Marketplace
and crossplanecontrib on DockerHub.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates all GitHub workflows to use the crossplane-contrib Docker user.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Verified these updates work correctly in GCP and AWS providers.