Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add Custom configurations and examples for some common resources #22

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

sergenyalcin
Copy link
Collaborator

Signed-off-by: Sergen Yalçın yalcinsergen97@gmail.com

Description of your changes

Fixes #15

This PR adds the following resources with their custom configurations and example manifests:

  • google_container_cluster
  • google_container_node_pool
  • google_service_account
  • google_monitoring_alert_policy
  • google_monitoring_notification_channel
  • google_monitoring_uptime_check_config

For monitoring resources, there is not need custom configuration. For cluster, node_pool and service_account resources, some custom configurations were added.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • For each added resource, an external resource was provisioned by using the example manifest.
  • For each added resource, update and delete operations were tested.

@sergenyalcin sergenyalcin self-assigned this Dec 16, 2021
@sergenyalcin sergenyalcin marked this pull request as ready for review December 16, 2021 16:10
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergenyalcin thanks! Just added some comments.
Not a huge issue but in general having separate commits before and after generation would help reviewing.

config/kubernetes/config.go Outdated Show resolved Hide resolved
apis/rconfig/config.go Outdated Show resolved Hide resolved
config/cloudplatform/config.go Outdated Show resolved Hide resolved
config/kubernetes/config.go Outdated Show resolved Hide resolved
config/provider.go Outdated Show resolved Hide resolved
examples/cloudplatform/serviceaccount.yaml Outdated Show resolved Hide resolved
examples/providerconfig/providerconfig.yaml Outdated Show resolved Hide resolved
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@turkenh turkenh merged commit 34c9d04 into crossplane-contrib:main Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom configurations and examples for some core resources
2 participants