Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Configure project and folder resources #53

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Mar 22, 2022

Description of your changes

There are two bugs mentioned below that are expected since external name configuration is required for google_project and google_folder resources. This PR adds configuration for these resources.

Fixes #45
Fixes #52

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unfortunately, I couldn't test this PR since I don't have permission to create a new project for my test account.
Asking for help from the community for testing 🙏 //cc @davidcollom, @danielinclouds, @mol-george.

You can have a provider image with the following steps:

export DOCKER_REGISTRY=<YOUR_DOCKERHUB_USERNAME>
export PLATFORMS=linux_amd64

make build publish
# Command will finish as below
# ...
# 13:19:48 [ .. ] docker build build-5090d4e0/provider-jet-gcp-controller-amd64
# sha256:0744c8a22c60d65d0dfed56340d585829a7c1b62a0043761f2cdf8c5830fd438
# 13:20:00 [ OK ] docker build build-5090d4e0/provider-jet-gcp-controller-amd64
# 13:20:01 [ .. ] docker build <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-amd64:v0.3.0-rc.14.gcc2574e
# 13:20:01 [ OK ] docker build <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-amd64:v0.3.0-rc.14.gcc2574e
# 13:20:01 [ .. ] docker build <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-controller-amd64:v0.3.0-rc.14.gcc2574e
# 13:20:12 [ OK ] docker build <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-controller-amd64:v0.3.0-rc.14.gcc2574e

# Remove "-amd64" part from image names
docker tag <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-amd64:v0.3.0-rc.14.gcc2574e <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp:v0.3.0-rc.14.gcc2574e
docker tag <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-controller-amd64:v0.3.0-rc.14.gcc2574e <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-controller:v0.3.0-rc.14.gcc2574e

docker push <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp:v0.3.0-rc.14.gcc2574e
docker push <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp-controller:v0.3.0-rc.14.gcc2574e

Now you can install the custom-built provider with:

kubectl crossplane install provider <YOUR_DOCKERHUB_USERNAME>/provider-jet-gcp:v0.3.0-rc.14.gcc2574e

turkenh added 3 commits March 22, 2022 12:59
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@ezgidemirel
Copy link
Collaborator

Could you please also add an example manifest for folder resource?

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh
Copy link
Collaborator Author

turkenh commented Mar 25, 2022

Merging this since it is a configuration change that we need to do anyway and there seems to be no side effect.

@turkenh turkenh merged commit 1a65335 into crossplane-contrib:main Mar 25, 2022
@turkenh turkenh deleted the configure-project branch March 25, 2022 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants