This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Configure External Name #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
muvaf
reviewed
Nov 19, 2021
config/overrides.go
Outdated
|
|
||
| func externalNameOverride() tjconfig.ResourceOption { | ||
| return func(resource *tjconfig.Resource) { | ||
| resource.ExternalName.GetExternalNameFn = common.GetNameFromFullyQualifiedID |
There was a problem hiding this comment.
GetExternalNameFn should be compatible with GetIDFn. Right now, it would return the last part of the ID as external name and then when it constructs the ID, it will copy that external name. My suggestion would be to use a provider-wide default for the whole resource.ExternalName configuration, instead of only resource.ExternalName.GetExternalNameFn
There was a problem hiding this comment.
I'll work on a provider-wide default for external name in a follow-up PR.
Reverted defaulting for now and moved to individual resource configs.
There was a problem hiding this comment.
I meant something like common.IdentifierFromProvider that has all sub-configs compatible for each other.
Signed-off-by: Hasan Turken <turkenh@gmail.com>
muvaf
approved these changes
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR configures external-name properly with latest Terrajet config options.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Deploy example compute instance.