rds.cluster: add ability to auto-generate password in referenced secret #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Bagri <ravibagri2@gmail.com>
Signed-off-by: Ravi Bagri <ravibagri2@gmail.com>
ravibagri5
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
Signed-off-by: Ravi Bagri <ravibagri2@gmail.com>
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
Signed-off-by: Ravi Kumar <ravibagri2@gmail.com>
Signed-off-by: Ravi Kumar <ravibagri2@gmail.com>
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
|
@ravibagri5, we need this PR for Uptest to work properly, can you please rebase the PR? |
@turkenf Sure. Thanks for the update. |
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
turkenf
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Many thanks for your efforts in this PR @ravibagri5, left a small comment for you to consider.
Signed-off-by: Ravi Kumar <ravibagri2@gmail.com>
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
Signed-off-by: Ravi Kumar <ravibagri2@gmail.com>
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
turkenf
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds the ability to auto-generate password for the rds cluster. This was already added for the RDS instance in the PR #628. Users need to opt-in by setting autoGeneratePassword as true while creating RDS cluster and should have a Secret reference. It will create if the referenced Secret does not exist and it will populate if it doesn't have the password for the given key.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests, local end-to-end test.