-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume upjet with custom metrics #597
Consume upjet with custom metrics #597
Conversation
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
0c348db
to
d1ae693
Compare
/test-examples="examples/ec2/vpc.yaml" |
Hi @turkenf, |
Hi @ulucinar
After the image was updated, I checked the status of the resource and waited enough time. I observed that the resource status remains
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ulucinar, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar LGTM!
Description of your changes
This PR bumps the upjet dependency to make the new custom Prometheus metrics available in the provider's runtime. Please see crossplane/upjet#170 for the available metrics and examples.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Please see crossplane/upjet#170.