Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume upjet with custom metrics #597

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Mar 8, 2023

Description of your changes

This PR bumps the upjet dependency to make the new custom Prometheus metrics available in the provider's runtime. Please see crossplane/upjet#170 for the available metrics and examples.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Please see crossplane/upjet#170.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Copy link
Collaborator Author

ulucinar commented Mar 8, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar ulucinar requested a review from turkenf March 8, 2023 12:30
@ulucinar
Copy link
Collaborator Author

ulucinar commented Mar 8, 2023

Hi @turkenf,
We can use the package ulucinar/provider-aws-amd64:d1ae6936 for testing upgrades from v0.30.0.

@turkenf
Copy link
Collaborator

turkenf commented Mar 9, 2023

Hi @ulucinar
I completed the test with the given ulucinar/provider-aws-amd64:d1ae6936 package. After creating a resource in v0.30.0, I changed the package. I edited the current resource and checked it successfully.

> kubectl get providerrevisions.pkg.crossplane.io
NAME                        HEALTHY   REVISION   IMAGE                                          STATE      DEP-FOUND   DEP-INSTALLED   AGE
provider-aws-2e7deee3c48d   True      2          ulucinar/provider-aws-amd64:d1ae6936           Active                                 12h
provider-aws-30b1a6158012   True      1          xpkg.upbound.io/upbound/provider-aws:v0.30.0   Inactive                               12h

After the image was updated, I checked the status of the resource and waited enough time. I observed that the resource status remains Ready=True, Synced=True:

> kubectl get vpc.ec2.aws.upbound.io/sample-vpc
NAME         READY   SYNCED   EXTERNAL-NAME           AGE
sample-vpc   True    True     vpc-086c63f5999fefef0   10h

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM!

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 025f49b into crossplane-contrib:main Mar 9, 2023
@ulucinar ulucinar deleted the bump-upjet-5377e5db7994 branch March 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants