add upbound credentials source #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
avalanche123
force-pushed
the
proidc-support
branch
from
777c2c9 to
a09c071
Compare
turkenh
approved these changes
Jun 21, 2023
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
avalanche123
force-pushed
the
proidc-support
branch
from
a64e5b9 to
60bb38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bulat Shakirzyanov 83289+avalanche123@users.noreply.github.com
Description of your changes
Add
Upboundcredentials source, similar to crossplane-contrib/provider-upjet-gcp#206 and crossplane-contrib/provider-upjet-aws#278I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I tried running
make reviewable testbut the golintci step kept timing out / getting SIGKILLed.