Configure a default poll jitter for the controllers #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/azure/resourcegroup.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes configuring a default poll jitter of 5% of the poll interval for up-to-date resources so that if the reconciliations of the resources are synchronized for some reason (e.g., pod restart), they will not be queued for reconciliation at the same moment. Also as the provider keeps reconciling the resources, the reconciliations will be randomly distributed. We initially start with a poll jitter of 5% of the poll interval and currently this interval is not configurable via the command-line options not to increase the configuration complexity. If there's need to configure the jitter for different environments, then we can add this option in a future PR.
The configured jitter is also dumped in the debug logs when the provider is starting:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested manually on this PR