feat(resource): add azurerm_api_management_custom_domain #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
add azurerm_api_management_custom_domain
Running uptest for this resource is not feasible because we require the principal_id from the system assigned identity of APIM to add an AccessPolicy for Azure KeyVault. We can't use user assigned identities due to an existing issue in the tf provider, as detailed in this link: hashicorp/terraform-provider-azurerm#18323.
Fixes #626
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
local via uptest with manual interaction