-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow publicIP to be referenced using selectors and Ref #652
fix: allow publicIP to be referenced using selectors and Ref #652
Conversation
Signed-off-by: Miguel Angel Ducanto Hadad <migueladh@ext.inditex.com>
/test-examples="examples/network/networkinterface-publicip.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @migueladh, left a few comments for you to consider.
Signed-off-by: Miguel Angel Ducanto Hadad <migueladh@ext.inditex.com>
Signed-off-by: Miguel Angel Ducanto Hadad <migueladh@ext.inditex.com>
/test-examples="examples/network/networkinterface-publicip.yaml" |
@migueladh, I left two more small comments and please sign |
Signed-off-by: Miguel Angel Ducanto Hadad <migueladh@ext.inditex.com>
@turkenf sorry for the delay, all done :) |
/test-examples="examples/network/networkinterface-publicip.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work in this PR @migueladh, LGTM.
Description of your changes
Fixes #78
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
kubectl get networkinterface.network.azure.upbound.io/example -o yaml