Fix #760 by making administrator_login & administrator_password optional for connection details

[niiku]

Description of your changes

As described in #760 disabling password auth (only enabling azure ad) results in a panic as no credential details are available. Within this PR checks are introduced which verify the existence of username/password and only then add it to the credential details.

As general "inspiration" I oriented the change on how it's done for MSSQL: https://github.com/crossplane-contrib/provider-upjet-azure/blob/main/config/sql/config.go#L39

Fixes #760

I have:

• Read and followed Crossplane's contribution process.
• [] Run make reviewable to ensure this PR is ready for review. <- I somehow didn't get that command running. But I doubt it's because of my code changes..
• [] Added backport release-x.y labels to auto-backport this PR if necessary. <- Not too sure. I need input from the maintainers if it makes sense to backport?

How has this code been tested

I run the fixed provider within my cluster with the example MR as described in the bug report. With the applied changes, the panic is not appearing and the .status of the FlexibleServer MR is updated when creating with disabled password auth.

A successful uptest run of the resource: https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/9483541667

[jeanduplessis]

/test-examples="examples/dbforpostgresql/v1beta2/flexibleserver.yaml"

[niiku]

@jeanduplessis Thanks a lot for letting the tests run.

I see the e2e tests failed because of:

2024-06-11T00:49:05.3192834Z     logger.go:42: 00:49:05 | case/0-apply | error: timed out waiting for the condition on flexibleservers/example
2024-06-11T00:49:05.3217259Z     logger.go:42: 00:49:05 | case/0-apply | command failure, skipping 5 additional commands
2024-06-11T00:49:06.3221590Z     logger.go:42: 00:49:06 | case/0-apply | running command: [/home/runner/work/provider-upjet-azure/provider-upjet-azure/.cache/tools/linux_x86_64/kubectl-v1.24.3 annotate managed --all upjet.upbound.io/test=true --overwrite]
....
2024-06-11T00:30:57.3562726Z     logger.go:42: 00:30:57 | case/0-apply |       message: 'cannot resolve references: mg.Spec.ForProvider.DelegatedSubnetID:
2024-06-11T00:30:57.3565030Z     logger.go:42: 00:30:57 | case/0-apply |         referenced field was empty (referenced resource may not yet be ready)'

resp.

    logger.go:42: 00:50:38 | case/0-apply |         Virtual Network Link Name: "example"): performing CreateOrUpdate: unexpected status 404 with error: ParentResourceNotFound: Failed to perform 'write' on resource(s) of type 'privateDnsZones/virtualNetworkLinks', because the parent resource '/subscriptions/2895a7df-ae9f-41b8-9e78-3ce4926df838/resourceGroups/example/providers/Microsoft.Network/privateDnsZones/example' could not be found.  []***]

I could be mistaken, but this does not seem to be related to my changes at all.

Is there a case where this e2e test for flexible server v1beta2 has run through? I surely could invest some time to fix the e2e tests - but first wanted to have confirmation from someone else that this is more of a "general e2e test"-issue than related to my code changes.

[turkenf]

Hey @niiku, many thanks for your effort and interest here, we appreciate it.

I could be mistaken, but this does not seem to be related to my changes at all.

Yes, this is not related to the change you made, the e2e test of the current version of the resource seems to be unverified. Dependent resources need to be checked and selectors need to be adjusted.

[niiku]

@turkenf Thanks a lot for your answer! I could have a look at the e2e tests. As far as I understood the code base, there aren't that many unit tests done for config.go - so I wanted to get some input how to best "bake in" the use case I added in form of tests. Might you guide me if you rather would like to see unit tests (as this might be well testable on this level) and/or have an e2e for this case as well?

[niiku]

@jeanduplessis @turkenf I think i might have fixed the e2e as simply the privat dns name wasn't set correctly. Could you let them run again?

[turkenf]

/test-examples="examples/dbforpostgresql/v1beta2/flexibleserver.yaml"

[turkenf]

Hey @niiku, I have manually checked the resource's examples/dbforpostgresql/v1beta2/flexibleserver.yaml YAML file except for the changes you have made so far and I think the following changes are considerable:

• We have an uptest.upbound.io/timeout annotation that we use in e2e tests, we use this annotation when the creation and deletion of the resource takes over 20 minutes. When I look at the Terraform documentation, I think it would be useful to add the annotation uptest.upbound.io/timeout: "3600", this gives us 1 hour for testing.
  As an example:

  provider-upjet-azure/examples/dbforpostgresql/v1beta1/virtualnetworkrule.yaml

  Line 10 in 0a511b8

  uptest.upbound.io/timeout: "3600"

• It would be logical to remove the spec.forProvider.zone field of the FlexibleServer resource since it is optional, so it will automatically be assigned to the available zone.

[turkenf]

/test-examples="examples/dbforpostgresql/v1beta2/flexibleserver.yaml"

[niiku]

I added the following changes:

• Added autoGeneratePassword because of

2024-06-12T07:56:29.1795017Z     logger.go:42: 07:56:29 | case/0-apply |       message: 'create failed: async create failed: failed to create the resource:
2024-06-12T07:56:29.1796616Z     logger.go:42: 07:56:29 | case/0-apply |         [***0 `administrator_password` is required when `create_mode` is `Default` and
2024-06-12T07:56:29.1798019Z     logger.go:42: 07:56:29 | case/0-apply |         `authentication.password_auth_enabled` is set to `true`  []***]'

• Removed the zone to allow better distribution
• Updated PostgreSQL version to 16 as it's latest

I would not recommend to increase the timeout - as this setup should be provisioned in like ~10min - so 30min as timeout is sufficient - if it takes longer it just delays the time until we get feedback from the e2e tests.

Could you run the e2e tests again?

[turkenf]

/test-examples="examples/dbforpostgresql/v1beta2/flexibleserver.yaml"

[turkenf]

/test-examples="examples/dbforpostgresql/v1beta2/flexibleserver.yaml"

[turkenf]

Many thanks for your effort @niiku 🙌