Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving datacatalog (2) resources to v1beta1 version #118

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Jan 16, 2023

Moving 2 resources to v1beta1 version

Description of your changes

Fixes #103

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual & Uptest:
google_data_catalog_tag - link
google_data_catalog_tag_template - link

@MyzaTaras MyzaTaras self-assigned this Jan 16, 2023
@MyzaTaras MyzaTaras force-pushed the issue-103 branch 2 times, most recently from 0809ced to b1d94f1 Compare January 16, 2023 18:20
@dverveiko
Copy link
Contributor

LGTM

@MyzaTaras MyzaTaras force-pushed the issue-103 branch 2 times, most recently from 2931191 to 5456d7c Compare January 17, 2023 09:55
@MyzaTaras MyzaTaras changed the title Moving datacatalog (8) resources to v1beta1 version Moving datacatalog (2) resources to v1beta1 version Jan 17, 2023
@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/datacatalog/tagtemplate.yaml"

@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/datacatalog/tag.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras LGTM!

@MyzaTaras MyzaTaras merged commit 322bd85 into crossplane-contrib:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving datacatalog (2) resources to v1beta1 version
3 participants