Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving datastore (1) resource to v1beta1 version #143

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Jan 18, 2023

Moving 1 resource to v1beta1 version

  • google_datastore_index

Description of your changes

Fixes #132

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Uptest:
Resource created successfully but Uptest returned error "Index already exist"

Manual:
google_datastore_index:
Screenshot 2023-01-20 at 11 06 14

@MyzaTaras MyzaTaras self-assigned this Jan 18, 2023
@MyzaTaras MyzaTaras force-pushed the issue-132 branch 11 times, most recently from 4582508 to c618ecf Compare January 20, 2023 09:10
@crossplane-contrib crossplane-contrib deleted a comment from dverveiko Jan 20, 2023
@crossplane-contrib crossplane-contrib deleted a comment from dverveiko Jan 20, 2023
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras LGTM!

@MyzaTaras MyzaTaras merged commit 5918603 into crossplane-contrib:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving datastore (1) resource to v1beta1 version
2 participants