Adds the required field spec.projectID for ProviderConfig creation …
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Upbound Signed-off-by: Jason Tang <jason@upbound.io>
|
There are some documentation improvements that we can make here before we merge. However, I was able to confirm that the control plane is successfully provisioning external infrastructure in GCP. |
Signed-off-by: Jason Tang <jason@upbound.io>
jastang
commented
Jun 15, 2023
| @@ -33,6 +33,7 @@ sources: | |||
| ref: spec.credentials.secretRef | |||
| showFields: | |||
| - spec.credentials.secretRef | |||
| - spec.projectID | |||
There was a problem hiding this comment.
@ulucinar @sergenyalcin for context, this and L93 is the core fix.
Everything else is a quick refresh of the configurable documentation in that this enables in the Console - I acknowledge that the content is not optimal, but addresses some gaps in the OIDC configuration process for the user which we will iterate on.
ulucinar
approved these changes
Jun 15, 2023
|
Successfully created backport PR #322 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in Upbound
Description of your changes
In Upbound,
package/auth.yamlis used to configure what fields are exposed to createProviderConfigobjects. The required fieldspec.projectIDwas missing for GCP.-->
Fixes #https://github.com/upbound/squad-upbound-cloud/issues/1248
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested