Temporarily disable configuring auth with secrets #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Tang <jason@upbound.io>
tnthornton
approved these changes
Jun 30, 2023
jeanduplessis
approved these changes
Jun 30, 2023
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Remove the auth source of "Secret" to temporarily disable storing user credentials as Kubernetes secrets as we harden our security posture for the console.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Local build and deploy to control plane: https://console.upbound.io/upbound/controlPlanes/upbound:gcp-no-secrets. Tested create, edit, and delete functionality.
Note that there is no longer a dropdown to select the
sourceas there is only one option (Upbound OIDC).