Added google_compute_router_peer. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradkwadsworth-mw
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
turkenf
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Thank you @bradkwadsworth-mw for this PR, I left a few comments to consider. In addition, if the resources are not uptestable, please add a screenshot under the How has this code been tested title. Please see: #198
turkenf
reviewed
Jul 26, 2023
turkenf
reviewed
Jul 27, 2023
added 4 commits
July 31, 2023 13:55
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
bradkwadsworth-mw
force-pushed
the
feature/add-compute-router-peer
branch
from
cc042a8 to
41b4d46
Compare
|
/test-examples="examples/compute/routerpeer.yaml" |
turkenf
approved these changes
Jul 31, 2023
turkenf
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added and tested the
google_compute_router_peerresource in this issue.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Applied example to existing GCP project.
Uptest: https://github.com/upbound/provider-gcp/actions/runs/5718696102/job/15495055680