Change the Reference.Type API with Reference.TerraformName
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
|
/test-examples="examples/cloudplatform/serviceaccount.yaml" |
ulucinar
approved these changes
May 10, 2024
There was a problem hiding this comment.
Thank you @sergenyalcin, lgtm. I'll also deprecate the config.Resource.References[*].Type in crossplane/upjet#400.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR changes the
Reference.TypeAPI withReference.TerraformName. This change is necessary to support the multiversion APIs.The reference configuration API in upjet includes a
Typefield that identifies the target reference field through the KubernetesKind. When you configure a reference field using thisTypeAPI, it searches for the target reference resource in the same API version. However, if the specific API version lacks the target reference resource, the reference cannot be resolved. To address this, we will use theTerraformNameAPI for configuring cross-resource references. This API allows the reference resolver to locate the target reference resource across its latest available version.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested locally.