Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add tags group #558

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

declement
Copy link
Contributor

@declement declement commented Jul 9, 2024

Description of your changes

This PR adds the ability to manage GCP resource tags through Crossplane.

This PR implements resources in #216. It is a follow up to #397 that were closed due to inactivity.

Implemented resources

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

This code has been tested manually (for creation, import and deletion) in a dedicated GCP project because Tag resources require existing parent resources.

google_tags_tag_key

Screenshot 2024-07-09 at 18 01 32

google_tags_tag_value

Screenshot 2024-07-09 at 18 09 57

google_tags_tag_binding

Screenshot 2024-07-09 at 18 15 16

declement added 2 commits July 9, 2024 23:02
Signed-off-by: declement <clementde@padok.fr>
Signed-off-by: declement <clementde@padok.fr>
@declement declement force-pushed the feat/add-tags-group branch from 8ab8e0b to 9d300dc Compare July 9, 2024 21:02
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/tags/v1beta1/tagbinding.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @declement, many thanks for the contribution. I left two small comments about manual intervention annotations.

examples/tags/v1beta1/tagbinding.yaml Show resolved Hide resolved
examples/tags/v1beta1/tagvalue.yaml Show resolved Hide resolved
Co-authored-by: Fatih Türken <103541666+turkenf@users.noreply.github.com>
Signed-off-by: declement <clementde@padok.fr>
@declement declement force-pushed the feat/add-tags-group branch from d73edd3 to a8cf767 Compare July 10, 2024 14:30
@declement
Copy link
Contributor Author

Thank you for the quick reply, your suggestions have been applied.

@declement
Copy link
Contributor Author

/test-examples="examples/tags/v1beta1/tagbinding.yaml,examples/tags/v1beta1/tagvalue.yaml,examples/tags/v1beta1/tagkey.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 10, 2024

/test-examples="examples/tags/v1beta1/tagbinding.yaml,examples/tags/v1beta1/tagvalue.yaml,examples/tags/v1beta1/tagkey.yaml"

Since you are a first-time contributor, you are not currently allowed to trigger uptest. Once this PR is merged, you can trigger it on new PRs you will open.

Additionally, it will skip uptests since there is manual intervention in all of the examples.

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@turkenf turkenf merged commit 61d09e2 into crossplane-contrib:main Jul 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants