Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigee): add google_apigee_envgroup_attachment #571

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jul 14, 2024

Description of your changes

add google_apigee_envgroup_attachment

Fixes #562

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

via crossplane-playground project in gcp - enabled apigee api first

kubectl get managed                                                    
NAME                                                   SYNCED   READY   EXTERNAL-NAME        AGE
environment.apigee.gcp.upbound.io/env-grp-attachment   True     True    env-grp-attachment   8m44s

NAME                                                    SYNCED   READY   EXTERNAL-NAME                         AGE
organization.apigee.gcp.upbound.io/env-grp-attachment   True     True    organizations/crossplane-playground   8m44s

NAME                                                SYNCED   READY   EXTERNAL-NAME        AGE
envgroup.apigee.gcp.upbound.io/env-grp-attachment   True     True    env-grp-attachment   8m44s

NAME                                                          SYNCED   READY   EXTERNAL-NAME                                                                                                       AGE
envgroupattachment.apigee.gcp.upbound.io/env-grp-attachment   True     True    organizations/crossplane-playground/envgroups/env-grp-attachment/attachments/8179636b-1695-4204-8674-2ff503bf4025   8m44s

NAME                                                SYNCED   READY   EXTERNAL-NAME        AGE
network.compute.gcp.upbound.io/env-grp-attachment   True     True    env-grp-attachment   8m44s

NAME                                                      SYNCED   READY   EXTERNAL-NAME        AGE
globaladdress.compute.gcp.upbound.io/env-grp-attachment   True     True    env-grp-attachment   8m44s

NAME                                                             SYNCED   READY   EXTERNAL-NAME                                                                                                AGE
connection.servicenetworking.gcp.upbound.io/env-grp-attachment   True     True    projects%2Fcrossplane-playground%2Fglobal%2Fnetworks%2Fenv-grp-attachment:servicenetworking.googleapis.com   8m44s

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @haarchri. I left small comments. It would also be nice if you mentioned the import and delete test in the description.

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri force-pushed the feature/apigee-envgroupattachment branch from b76d9b5 to 4ffafe3 Compare July 22, 2024 10:29
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@turkenf turkenf merged commit 3776aae into crossplane-contrib:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for google_apigee_envgroup_attachment resource
2 participants