Add a "Show diff" step to show diffs in case the make check-diff step fails #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
ci-improvements
branch
3 times, most recently
from
57bb60d to
86d84c8
Compare
… fails - The pull-docs make target does not honour Terraform provider plugin updates if the working Terraform provider repo already exists Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
ci-improvements
branch
from
86d84c8 to
072ca3f
Compare
turkenh
approved these changes
Nov 23, 2022
|
Thanks @turkenh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a
Show diffstep that's run if thecheck-diffstep fails in theCIpipeline to show what content changes are failing the job.Also, while working in the context of updating the Terraform provider plugin version, I realized we do not honor the declared Terraform provider version if the working directory for the Terraform provider repo already exists (under
.work). Previously we were removing this work directory as we are doing a sparse checkout. So, applied the same approach here.Relevant PR: crossplane-contrib/provider-upjet-aws#176
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Please see here:
https://github.com/upbound/provider-gcp/actions/runs/3533055974/jobs/5928190113
And in case
check-diffdoes not fail, this step is skipped:https://github.com/upbound/provider-gcp/actions/runs/3533076220/jobs/5928239220