feat(networkconnectivity): add Service Connection Policy support #624
Conversation
|
Working on a fix for this in |
|
Depends on fix included in #631 |
It might be better to test the Upjet update in this PR. |
Sure I'll rebase this onto that. brb |
rickard-von-essen
force-pushed
the
feature/service-connection-policy
branch
from
0bd131b to
ac1905f
Compare
rickard-von-essen
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
Rebased onto #631 |
|
/test-examples="examples/networkconnectivity/v1beta1/serviceconnectionpolicy.yaml" |
There was a problem hiding this comment.
Thank you for your effort @rickard-von-essen, left two comments for you to consider.
examples/networkconnectivity/v1beta1/serviceconnectionpolicy.yaml
Outdated
Show resolved
Hide resolved
|
/test-examples="examples/networkconnectivity/v1beta1/serviceconnectionpolicy.yaml" |
1 similar comment
|
/test-examples="examples/networkconnectivity/v1beta1/serviceconnectionpolicy.yaml" |
|
Great! Very happy to finally get this to the finishing line. This was a bit rough learning curve for me. 🫠 |
|
Thank you for your interest and effort @rickard-von-essen. Apart from my question above, in order to move this PR forward, I will need to take over the upjet upgrade PR and make some tests and additions there. I see changes in the APIs files of many resources, I will check them separately in the upjet upgrade PR and make the necessary additions/changes (will add the new ref fields from v1beta2 to v1beta1 apis). After merging the upgrade PR, we can rebase this PR and move it forward. |
Sounds great! Thanks for the support and please ping me there if there are any questions or anything I help out with. |
|
The upjet upgrade PR is merged @rickard-von-essen. Could you please rebase your branch to the main and squash your commits to make the commit history clean? |
This adds support for google_network_connectivity_service_connection_policy Terraform resource, see https://registry.terraform.io/providers/hashicorp/google/5.39.1/docs/resources/network_connectivity_service_connection_policy Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
rickard-von-essen
force-pushed
the
feature/service-connection-policy
branch
from
b1c12db to
5ce160a
Compare
|
/test-examples="examples/networkconnectivity/v1beta1/serviceconnectionpolicy.yaml" |
Description of your changes
This adds support for
google_network_connectivity_service_connection_policyTerraform resource, see Terraform - Google - Service Connection Policy.Includes #631
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Via uptest: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11480002642