Bump native tf provider to version 5.44.2 #641
Conversation
|
/test-examples="examples/storage/v1beta2/bucket.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
turkenf
force-pushed
the
bump-tf-5.44.2
branch
from
9c76cb9 to
c2d1dc6
Compare
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
|
/test-examples="examples/storage/v1beta2/bucket.yaml" |
|
/test-examples="examples/storage/v1beta1/bucket.yaml" |
|
/test-examples="examples/container/v1beta1/cluster.yaml" |
|
/test-examples="examples/container/v1beta2/cluster.yaml" |
|
I don't think it was smart to test different versions concurrently 🙂 |
|
/test-examples="examples/container/v1beta2/cluster.yaml" |
|
/test-examples="examples/cloudrun/v1beta1/v2job.yaml" |
|
/test-examples="examples/compute/v1beta1/disk.yaml" |
|
/test-examples="examples/compute/v1beta1/healthcheck.yaml" |
|
/test-examples="examples/compute/v1beta1/subnetwork.yaml" |
|
/test-examples="examples/container/v1beta1/nodepool.yaml" |
| @@ -13,6 +13,40 @@ import ( | |||
| v1 "github.com/crossplane/crossplane-runtime/apis/common/v1" | |||
| ) | |||
|
|
|||
| type AdditionalNodeNetworkConfigsInitParameters struct { | |||
There was a problem hiding this comment.
Should we backport this and other empty structs from the changes in the API of the Cluster.container resource?
There was a problem hiding this comment.
We discussed this topic off-channel. Here's the summary: Automatic backporting script begins from "root types", such as ClusterInitParameters, ClusterParameters, and ClusterObservation, and backports only the types that descend from their type hierarchy. Doing so was necessary to handle some edge cases, which caused the “same” struct to have a different name in newer API versions. Because these empty structs, mentioned in the review comment, are not used in anywhere, they are not backported. I argue that we shouldn't backport them manually, simply because doing so won't have any benefits.
| @@ -188,7 +188,7 @@ type HealthCheckedTargetsInternalLoadBalancersParameters struct { | |||
|
|
|||
| // The type of load balancer. This value is case-sensitive. Possible values: ["regionalL4ilb", "regionalL7ilb", "globalL7ilb"] | |||
| // +kubebuilder:validation:Optional | |||
| LoadBalancerType *string `json:"loadBalancerType" tf:"load_balancer_type,omitempty"` | |||
| LoadBalancerType *string `json:"loadBalancerType,omitempty" tf:"load_balancer_type,omitempty"` | |||
There was a problem hiding this comment.
We should backport the changes in this file.
There was a problem hiding this comment.
Done. I've seen inconsistencies in generating of omitempty tags. Either there's an edge case that I don't know about or there's a bug that omits generating them. If it's because of a bug and we fix it, we don't need any modifications to our backporting procedure, i.e., we don't need to backport struct tags.
There was a problem hiding this comment.
Adding omitempty tags didn't result in any changes in make generate, which was obvious to me only in hindsight 🙂
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
|
/test-examples="examples/container/v1beta1/cluster.yaml" |
Description of your changes
In this PR:
v5.44.2I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Will test with uptest and manually
examples/cloudrun/v1beta1/v2job.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11662125657examples/compute/v1beta1/disk.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11662144562examples/compute/v1beta1/healthcheck.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11662155721examples/compute/v1beta1/subnetwork.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11662165529examples/container/v1beta1/cluster.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11663588916examples/container/v1beta1/nodepool.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11662176035examples/container/v1beta2/cluster.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11635738314examples/storage/v1beta1/bucket.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11635268472examples/storage/v1beta2/bucket.yaml=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/11635198174