Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataplex): add aspect_type resource #662

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

nilan3
Copy link
Contributor

@nilan3 nilan3 commented Nov 27, 2024

Description of your changes

Add resources for the following terraform resources:

  • google_dataplex_aspect_type

Fixes #

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/aspecttype.yaml"

--- PASS: kuttl (45.11s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (44.02s)
PASS
10:54:19 [ OK ] running automated tests
image

@nilan3 nilan3 marked this pull request as ready for review November 27, 2024 12:50
@nilan3
Copy link
Contributor Author

nilan3 commented Nov 27, 2024

/test-examples="examples/dataplex/v1beta1/aspecttype.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @nilan3, I left a comment about external-name configuration for you to consider.

config/externalname.go Outdated Show resolved Hide resolved
@nilan3 nilan3 force-pushed the feature/dataplex_aspecttype branch from e9540d9 to 1a94808 Compare December 3, 2024 11:05
@nilan3
Copy link
Contributor Author

nilan3 commented Dec 3, 2024

/test-examples="examples/dataplex/v1beta1/aspecttype.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Dec 5, 2024

If we look at the types.go file, the location field still appears as optional. Could you please add the data plex group under this line in the provider.go file?

ProviderConfiguration.AddConfig(dataplex.Configure)

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 5, 2024

If we look at the types.go file, the location field still appears as optional. Could you please add the data plex group under this line in the provider.go file?

ProviderConfiguration.AddConfig(dataplex.Configure)

Thanks for the feedback, that change appears to have fixed it

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 5, 2024

/test-examples="examples/dataplex/v1beta1/aspecttype.yaml"

config/dataplex/config.go Outdated Show resolved Hide resolved
nilan3 and others added 5 commits December 5, 2024 16:47
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf force-pushed the feature/dataplex_aspecttype branch from 8161138 to c5495a6 Compare December 5, 2024 13:50
@turkenf
Copy link
Collaborator

turkenf commented Dec 5, 2024

/test-examples="examples/dataplex/v1beta1/aspecttype.yaml"

https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/12181104764

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your effort @nilan3, I had to push a commit to include this PR in the release we will be making today 🙂

@turkenf turkenf merged commit b2f9284 into crossplane-contrib:main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants