Report CRD breaking API schema changes with a report-breaking-changes CI job #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
integrate-crddiff
branch
from
d73cae8 to
bce035c
Compare
… CI job Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
integrate-crddiff
branch
from
bce035c to
056602e
Compare
ulucinar
changed the title
ulucinar
force-pushed
the
integrate-crddiff
branch
2 times, most recently
from
28f9458 to
056602e
Compare
ulucinar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a new
report-breaking-changesCI job that detects and reports breaking API changes between the two revisions of a generated managed resource definition using the crddiff tool.Currently, we would like to detect and report breaking API changes and not prevent them. In later iterations, we would like trigger uptests on breaking changes.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Validated using a change that introduces:
If no API changes in the CRDs (breaking or non-breaking) are detected, then the reporting step is skipped: