Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProviderSpec credentialsSecretRef optional #115

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

hasheddan
Copy link
Member

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Description of your changes

Makes the credentialsSecretRef field optional in ProviderSpec such that alternative auth methods can be utilized without having to reference a Secret.

Ref: crossplane-contrib/provider-aws#126 (comment)

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.
  • Updated any relevant documentation, examples, or release notes.
  • Updated the RBAC permissions in clusterrole.yaml to include any new types.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan requested review from negz and muvaf February 11, 2020 17:35
@upbound-bot
Copy link
Collaborator

86% (0.0%) vs master 86%

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but once this is merged I believe every managed resource controller will need to be updated to reflect the changes (e.g. checking whether the ref is now nil).

@hasheddan
Copy link
Member Author

@negz that is correct 👍 I am happy to make those updates. We could also not make it a pointer, then we would just get empty strings and fail to get the secret, but I feel like that would go against our conventions so I would prefer to just make the updates if that sounds good

@negz
Copy link
Member

negz commented Feb 12, 2020

@hasheddan SGTM - I imagine the updates should be fairly mechanical.

@hasheddan
Copy link
Member Author

@negz anything else needed here?

@negz negz merged commit e599809 into crossplane:master Feb 13, 2020
@negz
Copy link
Member

negz commented Feb 13, 2020

Nope - just forgot to hit merge. :)

@hasheddan
Copy link
Member Author

@negz thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants