Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to v0.13.0 #352

Closed

Conversation

saschagrunert
Copy link
Contributor

@saschagrunert saschagrunert commented Sep 5, 2022

Description of your changes

This also bumps related dependencies and adapts required code paths.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This also bumps related dependencies and adapts required code paths.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@negz
Copy link
Member

negz commented Sep 17, 2022

I'm a +1 on prioritizing this, especially because client-go v0.25.0 will bring in a bunch of client-side performance improvements for clusters operating with a lot of API groups (i.e. CRDs).

@negz
Copy link
Member

negz commented Sep 17, 2022

@saschagrunert Before I merge, can you elaborate on how (or if) you've tested this?

@saschagrunert
Copy link
Contributor Author

saschagrunert commented Sep 19, 2022

@saschagrunert Before I merge, can you elaborate on how (or if) you've tested this?

I just verified it via the CI, no further manual tests have been done on my side.

@negz
Copy link
Member

negz commented Sep 20, 2022

I just verified it via the CI, no further manual tests have been done on my side.

We typically like to at least build crossplane/crossplane against the updated deps (e.g. using a replace in the go.mod to point runtime at your branch) and make sure it seems to run. Would you be able to do that? I know you use runtime in a different project than us.

@negz negz closed this in #375 Jan 25, 2023
@saschagrunert saschagrunert deleted the controller-runtime branch January 26, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants