updates controller runtime to 0.14.1, implementing new subresource (writer/reader) client interfaces, updating all tests #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient interfaces, updating all tests Signed-off-by: Liam Baker <62133605+VariableExp0rt@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liam Baker 62133605+VariableExp0rt@users.noreply.github.com
Description of your changes
This change updates the dependency on controller-runtime to v0.14.1. As far as I could see the bump introduced a few interesting changes related to
client.SubResourceClient. The mocked client needed updates to introduce the additional methods expected as part of that interface (namely aSubResourcemethod) and some mocked function ((Get|Create|Update|Patch)SubResource).Happy to amend this if there are any additional comments/changes necessary, this is also my first contribution (mostly anywhere) so apologies in advance if it's not up to scratch.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable test