Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pkg/resource: output progress logs in applicators #532

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 4, 2023

Add progress logs to the applicators:

  • print creations
  • print updates/patches with diff
  • be silent on noop.

Based on #491

Signed-off-by: Dr. Stefan Schimanski stefan.schimanski@upbound.io

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
…e applicator

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
@sttts sttts requested review from a team as code owners September 4, 2023 08:27
@sttts sttts requested review from muvaf and pedjak September 4, 2023 08:27
@sttts sttts changed the title pkg/resource: output progress logs in applicators WIP: pkg/resource: output progress logs in applicators Sep 4, 2023
@sttts sttts mentioned this pull request Sep 7, 2023
3 tasks
@phisco
Copy link
Contributor

phisco commented Nov 16, 2023

@sttts, this PR is marked as ready for review, but has WIP in the title, should we move it to draft or consider it actually ready for review?

@sttts sttts marked this pull request as draft November 16, 2023 10:08
@sttts
Copy link
Contributor Author

sttts commented Nov 16, 2023

@phisco with @pedjak's SSA work I expect the applicators basically going away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants