Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency protobuf to v5.28.2 #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 18, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
protobuf ==5.27.2 -> ==5.28.2 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@negz
Copy link
Member

negz commented Sep 19, 2024

I'm going to leave this one for the moment.

I tried bumping the protobuf version locally and running hatch generate:protoc, but I still see the files are generated with 5.27.2. I get the same error this PR does when I run the unit tests.

Perhaps this is because we're using grpc_tools.protoc to generate the files, and that that tool needs updating?

@bobh66
Copy link
Collaborator

bobh66 commented Sep 19, 2024

Perhaps this is because we're using grpc_tools.protoc to generate the files, and that that tool needs updating?

Yes - the same error occurred in #86 and #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants