e2e: replace sleep commands with wait directives of the related tools #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <me@muvaf.com>
negz
reviewed
Jun 11, 2021
hasheddan
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
@muvaf this definitely seems like an improvement here, thanks! These tests were originally set up quickly and I think there are plenty of optimizations that can be made as part of the conformance effort. I'd also like for us to nail down what is causing the increased run time here, which may be related to package manager having more "resource has been modified" errors when installing CRDs. I'll investigate as a follow up 👍🏻
This was referenced Jun 14, 2021
turkenh
added a commit
to turkenh/provider-sql
that referenced
this pull request
Aug 25, 2021
Following crossplane-contrib/provider-aws#711 Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
added a commit
to turkenh/provider-helm
that referenced
this pull request
Aug 25, 2021
Following crossplane-contrib/provider-aws#711 Signed-off-by: Hasan Turken <turkenh@gmail.com>
This was referenced Aug 25, 2021
turkenh
added a commit
to turkenh/provider-sql
that referenced
this pull request
Aug 27, 2021
Following crossplane-contrib/provider-aws#711 Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 18b7c70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We're seeing increase in e2e test failures due to conditions being not met after a specific duration. Increasing the timeout would just make it take longer because the checks were not done periodically. So, I changed it to run periodically and use the related tools' waiting mechanisms wherever possible, like
helm's--waitflag andkubectl wait --timeout=60scommand.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually with
make e2e